Skip to content

Lab 6 — Code Review & Quality

Goal

Practice review as collaborative defect prevention and knowledge sharing.

Reviewer checklist

  • Does the change satisfy its issue/requirement?
  • Is there unnecessary complexity or duplication?
  • Are names and interfaces clear?
  • Are failure cases handled?
  • Are tests meaningful and maintainable?
  • Does the change introduce security/privacy risk?
  • Is documentation or an ADR needed?

Task

Review a peer pull request and provide at least:

  • One question about intent or assumptions.
  • One concrete improvement suggestion.
  • One positive observation tied to an engineering principle.

The author should respond to each review item and record which changes were accepted or rejected with rationale.